Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Deprecate classes in org.opensearch.action.support.master (#3593) #3609

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Jun 16, 2022

Description

Backport PR #3593 / commit 223d472 to 2.x branch

To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base.
In PR #3597, the package org.opensearch.action.support.master has be renamed to org.opensearch.action.support.clustermanager, and the classes with "master" name are renamed as well.

This PR adds the old package and classes back to keep the backwards compatibility and marks them as deprecated.
Apply 3 changes to the original classes in the package org.opensearch.action.support.master.
1 Remove all the methods in the classes.
2 Make them extend the corresponding classes with "cluster manager" name.
3 Add the same constructors with the corresponding "cluster manager" classes.

Issues Resolved

The second step for issue #3542 on 2.x branch.
It will be resolved by a following PR to rename and deprecate the public methods and variables in the package.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng changed the title Deprecate classes in org.opensearch.action.support.master (#3593) [2.x] Deprecate classes in org.opensearch.action.support.master (#3593) Jun 16, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d1e239a
Log 6073

Reports 6073

@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments deprecate v2.1.0 Issues and PRs related to version 2.1.0 labels Jun 16, 2022
@tlfeng tlfeng marked this pull request as ready for review June 16, 2022 20:51
@tlfeng tlfeng requested review from a team and reta as code owners June 16, 2022 20:51
@tlfeng tlfeng added the enhancement Enhancement or improvement to existing feature or request label Jun 17, 2022
@tlfeng tlfeng merged commit 9d312d3 into opensearch-project:2.x Jun 20, 2022
@tlfeng tlfeng deleted the 2.x-deprecate-master-package branch July 30, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments deprecate enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants